fix(deploy): use FQDN for SpiceDB endpoint in stage#441
Merged
Conversation
OpenShift service serving certificates have SANs for the full service DNS name (kartograph-spicedb.kartograph-stage.svc), not the short name. TLS cert verification fails with "Peer name kartograph-spicedb is not in peer certificate". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe change adds a new configuration entry Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
jsell-rh
added a commit
that referenced
this pull request
May 2, 2026
OpenShift service serving certificates have SANs for the full service DNS name (kartograph-spicedb.kartograph-stage.svc), not the short name. TLS cert verification fails with "Peer name kartograph-spicedb is not in peer certificate". Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jsell-rh
added a commit
that referenced
this pull request
May 2, 2026
OpenShift service serving certificates have SANs for the full service DNS name (kartograph-spicedb.kartograph-stage.svc), not the short name. TLS cert verification fails with "Peer name kartograph-spicedb is not in peer certificate". Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenShift service serving certs have SANs for the full service DNS name (
kartograph-spicedb.kartograph-stage.svc), not the short name (kartograph-spicedb). The TLS client verifies the hostname against the cert and fails with:"Peer name kartograph-spicedb is not in peer certificate".Adds
SPICEDB_ENDPOINToverride in the stage overlay to use the FQDN.🤖 Generated with Claude Code
Summary by CodeRabbit